Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set_cookie() does not use Config\Cookie values #6544

Merged
merged 6 commits into from
Sep 20, 2022
Merged

fix: set_cookie() does not use Config\Cookie values #6544

merged 6 commits into from
Sep 20, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 15, 2022 •
edited
Loading

Description
Fixes #6540

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Sep 15, 2022
@kenjis kenjis mentioned this pull request Sep 15, 2022
Closed
MGatner
MGatner approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. Should this merit a security advisory?

@kenjis kenjis force-pushed the fix-set-cookie branch 4 times, most recently from a0be875 to 97e2bb7 Compare September 16, 2022 08:42
kenjis and others added 2 commits September 19, 2022 07:13
@kenjis @samsonasik
refactor: add instanceof
620b389 
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@kenjis
docs: use classname alias
2955253
@kenjis kenjis merged commit 5a0f1e3 into codeigniter4:develop Sep 20, 2022
@kenjis kenjis deleted the fix-set-cookie branch September 20, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: set_cookie not using default value of $secure from config
3 participants
@kenjis @samsonasik @MGatner