Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:
required_without
rule logic inValidation
class. #6589fix:
required_without
rule logic inValidation
class. #6589Changes from 1 commit
7ecd9b3
0dbd648
2bdb36c
64924aa
b8f15b6
3ea0c6a
283edf1
288f37b
2e62c82
2a751c6
d42087b
70ca497
cb5d045
df18a57
16cdf1e
0779cc4
445f9fa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the implication of the
$now
? We have a$keyField
then$nowKeyField
. Then we have a$nowField
and$nowFieldValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this scenario, the implication of these name I set show as below .
$keyField
=> the key field is being passed in now (like:a.0.c
,a.1.c
).$nowKeyField
=> the index of key field is being passed in now (like:1
of a.1.c,2
of a.2.c).$nowField
=> the field ofrequired_without
is changed from asterisk field to current field (like:a.*.b
=>a.0.b
,a.1.b
...etc).$nowFieldValue
=> the value of current field in data set.I think the name of these variables aren't the best, or are there more suitable names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't understand what the variable names mean. Variable names need to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, do you guys have any suggestion for these variable names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this naming is ok, more readability.
I change it immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the name of
$fieldIndex
is more appropriate to show the index of the field.More readability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been modified, review please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index implies 0, 1, 2, ...
But it is an array key and is a string.
$fieldKey
is better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you.
I will change that.