Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing CLIRequest::getCookie() #6646

Merged
merged 5 commits into from
Oct 9, 2022
Merged

fix: Add missing CLIRequest::getCookie() #6646

merged 5 commits into from
Oct 9, 2022

Conversation

sclubricants
Copy link
Member

@sclubricants sclubricants commented Oct 7, 2022 •
edited
Loading

This PR fixes #6642

It adds the getCookie() method to CLIRequest. This method may be called by cookie_helper get_cookie() where a script is used by both CLI and http.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@sclubricants
Add CLIRequest::getCookie()
c1d0b10 
This is a placeholder method. Cookie helper may call getCookie() with a CLI Request.
@sclubricants sclubricants added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 7, 2022
kenjis
kenjis reviewed Oct 7, 2022
View reviewed changes
system/HTTP/CLIRequest.php Outdated Show resolved Hide resolved
@kenjis kenjis added the tests needed Pull requests that need tests label Oct 7, 2022
@kenjis
Copy link
Member

kenjis commented Oct 7, 2022

Please add test code.

We expect all contributions to conform to our style guide, be commented (inside the PHP source files), be documented (in the user guide), and unit tested (in the test folder).
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#contributions

MGatner
MGatner approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenjis kenjis removed the tests needed Pull requests that need tests label Oct 8, 2022
kenjis
kenjis reviewed Oct 8, 2022
View reviewed changes
system/HTTP/CLIRequest.php Outdated Show resolved Hide resolved
@sclubricants @kenjis
Update system/HTTP/CLIRequest.php
7faeeaa 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@kenjis kenjis merged commit 3daf93b into codeigniter4:develop Oct 9, 2022
@kenjis kenjis changed the title Add CLIRequest::getCookie() fix: Add missing CLIRequest::getCookie() Oct 9, 2022
@kenjis kenjis mentioned this pull request Oct 9, 2022
Merged
2 tasks
@sclubricants sclubricants deleted the RequestCLIgetCookie branch October 10, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: CLIRequest::getCookie() does not exist
3 participants
@sclubricants @kenjis @MGatner