Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded $logger property in Session #6647

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Conversation

paulbalandan
Copy link
Member

Description
Session already imports the $logger property through the use of LoggerAwareTrait. So this declaration is redundant.

Moreover, if a user accidentally uses v2 or v3 of psr/log, like here which I think what happened, this will cause an incompatible declaration error.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 8, 2022
@paulbalandan paulbalandan merged commit 046c540 into develop Oct 8, 2022
@paulbalandan paulbalandan deleted the session-logger branch October 8, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants