Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug that esc() accepts invalid context '0' #6722

Merged
merged 1 commit into from
Oct 20, 2022
Merged

fix: bug that esc() accepts invalid context '0' #6722

merged 1 commit into from
Oct 20, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 20, 2022 •
edited
Loading

Description

  • fix a bug that esc() accepts invalid context '0'

See #6715 (comment)

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 20, 2022
@kenjis kenjis mentioned this pull request Oct 20, 2022
Merged
2 tasks
@samsonasik samsonasik merged commit 77e5dcf into codeigniter4:develop Oct 20, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-esc-context-0 branch October 20, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @samsonasik @paulbalandan