Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete admin/module directory #6775

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Delete admin/module directory #6775

merged 1 commit into from
Oct 29, 2022

Conversation

paulbalandan
Copy link
Member

Description
If I'm not mistaken, this was used for the devstarter which was abandoned long ago so this needs not to be maintained any more.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member

kenjis commented Oct 28, 2022

I thought it was a template for CI4 packages.

@paulbalandan
Copy link
Member Author

But was this ever used? I'm not sure either.

@kenjis
Copy link
Member

kenjis commented Oct 28, 2022

It seems admin/module is not documented anywhere, so maybe nobody knows it.

It would be better to have templates and instructions for those who want to make CI4 packages.

@MGatner
Copy link
Member

MGatner commented Oct 29, 2022

Let's remove it. It was indeed a template for libraries that I started but I quickly found it was easier to start from one of my existing libraries and stopped keeping up with it. Most of what Modules was trying to accomplish is now covered by DevKit, and the remaining piece (test scaffold) ends up getting in the way more than being helpful.

@MGatner
Copy link
Member

MGatner commented Oct 29, 2022

If we really want to offer this feature in the future it should be a GitHub Template Repository, which would take it out of this repo and make maintenance easier.

@paulbalandan paulbalandan merged commit ef6a516 into develop Oct 29, 2022
@paulbalandan paulbalandan deleted the delete-admin-module branch October 29, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants