Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor assertHeaderEmitted and assertHeaderNotEmitted #6806

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Refactor assertHeaderEmitted and assertHeaderNotEmitted #6806

merged 1 commit into from
Nov 2, 2022

Conversation

paulbalandan
Copy link
Member

Description
Reuse existing utility method

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Nov 1, 2022
MGatner
MGatner approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice dedupe

@paulbalandan paulbalandan merged commit 9dd92e0 into codeigniter4:develop Nov 2, 2022
@paulbalandan paulbalandan deleted the refactor-assert-headers branch November 2, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @MGatner