Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: variable types for PHPStan 1.9.0 #6810

Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix: variable types for PHPStan 1.9.0 #6810

merged 1 commit into from
Nov 4, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 3, 2022

Description

  • PHPStan 1.9.0 reported errors.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis
fix: variable types
0e2a6a5 
PHPStan 1.9.0 reported errors.
@kenjis kenjis changed the title fix: variable types fix: variable types for PHPStan 1.9.0 Nov 4, 2022
@kenjis kenjis added the refactor Pull requests that refactor code label Nov 4, 2022
@kenjis kenjis mentioned this pull request Nov 4, 2022
Merged
2 tasks
@samsonasik samsonasik merged commit a031b9d into codeigniter4:develop Nov 4, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-phpstan-190-erros branch November 4, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik