Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Auto Routing Improved] fallback to default method #7162

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 22, 2023

Description
If there is no method in the controller for the request URI, fallback to the default method.

E.g.:
GET /product/15
Product::get15() Method not found
Product::getIndex($id = '') Method found and run getIndex('15')

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.4 labels Jan 22, 2023
@kenjis kenjis force-pushed the feat-auto-routes-index-fallback branch from c136237 to 701bddd Compare January 22, 2023 05:31
@kenjis kenjis force-pushed the feat-auto-routes-index-fallback branch from 701bddd to d93340e Compare January 27, 2023 00:52
@kenjis
Copy link
Member Author

kenjis commented Jan 27, 2023

Added the docs.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice feature.

@kenjis kenjis merged commit 4397d42 into codeigniter4:4.4 Jan 27, 2023
@kenjis kenjis deleted the feat-auto-routes-index-fallback branch January 27, 2023 23:50
@atiabjobayer
Copy link

Can we please get this commit released asap? This is a much needed fix.

@kenjis
Copy link
Member Author

kenjis commented Jul 30, 2023

We hope to release v4.4.0 soon.

@atiabjobayer
Copy link

Thank you for your reply. Any estimation when 4.4 might be released?

@kenjis
Copy link
Member Author

kenjis commented Jul 31, 2023

Personally, I would like to release it within a week or two if possible, or by the end of August at the latest.

However, CodeIgniter has no official release schedule.

@atiabjobayer
Copy link

@kenjis Just a bump if you could release this PR fast. :')

@kenjis
Copy link
Member Author

kenjis commented Aug 13, 2023

I created the issue #7812 to make the current status clear.
We have some PRs to review.
Testing and reviewing these are welcome, and makes the release sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants