Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handling of null bytes in Exceptions::renderBacktrace() #7306

Merged
merged 1 commit into from
Feb 26, 2023
Merged

fix: handling of null bytes in Exceptions::renderBacktrace() #7306

merged 1 commit into from
Feb 26, 2023

Conversation

paulbalandan
Copy link
Member

Description
Fixes #7262.

The clean_path() function should not be there to begin with.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 26, 2023
@samsonasik samsonasik merged commit 4c69da2 into codeigniter4:develop Feb 26, 2023
@samsonasik
Copy link
Member

Thank you @paulbalandan

@kenjis kenjis changed the title Fix handling of null bytes in Exceptions::renderBacktrace() fix: handling of null bytes in Exceptions::renderBacktrace() Feb 27, 2023
@paulbalandan paulbalandan deleted the render-backtrace-fix-nul branch February 27, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Debug\Exceptions cannot handle null character
3 participants
@paulbalandan @samsonasik @kenjis