Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [Entity] fix incorrect return value #7542

Merged
merged 1 commit into from
Jun 6, 2023
Merged

refactor: [Entity] fix incorrect return value #7542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions system/Entity/Entity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ public function cast(?bool $cast = null)
*
* @param array|bool|float|int|object|string|null $value
*
* @return $this
* @return void
*
* @throws Exception
*/
Expand All @@ -452,16 +452,14 @@ public function __set(string $key, $value = null)
if (method_exists($this, $method)) {
$this->{$method}($value);

return $this;
return;
}

// Otherwise, just the value. This allows for creation of new
// class properties that are undefined, though they cannot be
// saved. Useful for grabbing values through joins, assigning
// relationships, etc.
$this->attributes[$dbColumn] = $value;

return $this;
}

/**
Expand Down