Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [4.4] add types for phpstan #7723

Merged
merged 3 commits into from
Jul 22, 2023
Merged

refactor: [4.4] add types for phpstan #7723

merged 3 commits into from
Jul 22, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 21, 2023 •
edited
Loading

Description
Supersedes #7721
See #7713

  • add types to new classes or private methods

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.4 refactor Pull requests that refactor code labels Jul 21, 2023
@kenjis kenjis merged commit df5973b into codeigniter4:4.4 Jul 22, 2023
50 checks passed
@kenjis kenjis deleted the refactor-add-return-types-4.4 branch July 22, 2023 07:59
@kenjis kenjis mentioned this pull request Jul 22, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.4 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan