Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: $sensitiveDataInTrace does not work #7725

Merged
merged 5 commits into from
Jul 25, 2023
Merged

fix: $sensitiveDataInTrace does not work #7725

merged 5 commits into from
Jul 25, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 21, 2023 •
edited
Loading

Description
Fixes #7708

  • fix: params defined in $sensitiveDataInTrace may not be masked
  • fix: maskSensitiveData() may mask backtrace data like file

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 21, 2023
@kenjis kenjis mentioned this pull request Jul 21, 2023
Closed
MGatner
MGatner approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice tests.

@kenjis kenjis merged commit 48d5ded into codeigniter4:develop Jul 25, 2023
50 checks passed
@kenjis kenjis deleted the fix-sensitiveDataInTrace branch July 25, 2023 21:12
@kenjis kenjis mentioned this pull request Jul 25, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: $sensitiveDataInTrace does not work
2 participants
@kenjis @MGatner