Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto route legacy does not work #7871

Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix: auto route legacy does not work #7871

merged 2 commits into from
Aug 28, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 27, 2023

Description
From https://forum.codeigniter.com/showthread.php?tid=88353&pid=412136#pid412136

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.4 labels Aug 27, 2023
@samsonasik
Copy link
Member

let's merge, thank you @kenjis

@samsonasik samsonasik merged commit 1804bab into codeigniter4:develop Aug 28, 2023
51 checks passed
@kenjis kenjis deleted the fix-auto-route-legacy branch August 29, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
4.4 bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik