Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use PHP_VERSION_ID instead of PHP_VERSION #7913

Merged
merged 1 commit into from
Sep 8, 2023
Merged

test: use PHP_VERSION_ID instead of PHP_VERSION #7913

merged 1 commit into from
Sep 8, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 8, 2023

Description
To make the code easy to understand.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only refactor Pull requests that refactor code labels Sep 8, 2023
@datamweb
Copy link
Contributor

datamweb commented Sep 8, 2023

How about index.php, spark ?

@kenjis
Copy link
Member Author

kenjis commented Sep 8, 2023

Of course, you or anyone can refactor.

@neznaika0
Copy link
Contributor

and Autoloader

CodeIgniter4/system/Autoloader/Autoloader.php

Line 344 in 1891963

if (version_compare(PHP_VERSION, '8.0.0', '>=')) {

@kenjis kenjis merged commit 64c9a70 into codeigniter4:develop Sep 8, 2023
49 checks passed
@kenjis kenjis deleted the test-refactor-PHP_VERSION branch September 8, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neznaika0 neznaika0 neznaika0 approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @datamweb @neznaika0 @paulbalandan