fix: CI returns "200 OK" when PageNotFound #8011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
kenjis
commented
Oct 6, 2023
| @@ -979,8 +979,7 @@ protected function display404errors(PageNotFoundException $e) | |||
| // Display 404 Errors | |||
| $this->response->setStatusCode($e->getCode()); | |||
|
|
|||
| echo $this->outputBufferingEnd(); | |||
| flush(); | |||
| $this->outputBufferingEnd(); | |||
There was a problem hiding this comment.
Reading the code now, I don't understand why it was flushing here.
96a0d4f3#diff-d913ae68414ad947e24e588e6ee68d68194142a8aae52e61e0aab2cc7f120e0cL982
No response headers have been sent yet.
There was a problem hiding this comment.
It looks like @iRedds was just replacing the functionality that was already there.
kenjis
changed the title
kenjis
changed the title
ddevsr
approved these changes
Oct 6, 2023
kenjis
force-pushed
the
fix-200-OK-to-404
branch
from
320f408
to
33708a8
Compare
MGatner
approved these changes
Oct 8, 2023
michalsn
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8009
Navigate to
http://localhost:8080/404, you will get "200 OK" status code.Checklist: