Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make discoverFilters() deprecated #8014

Merged
merged 2 commits into from
Oct 10, 2023
Merged

docs: make discoverFilters() deprecated #8014

merged 2 commits into from
Oct 10, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 6, 2023 •
edited
Loading

Description
See #7955 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request Oct 6, 2023
Merged
5 tasks
MGatner
MGatner approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right way to do it.

@kenjis kenjis merged commit 0d94606 into codeigniter4:develop Oct 10, 2023
62 checks passed
@kenjis kenjis deleted the deprecate-filter-discovery branch October 10, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner