Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make IncomingRequest::$uri protected #8067

Merged
merged 2 commits into from
Oct 22, 2023
Merged

refactor: make IncomingRequest::$uri protected #8067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f35bb0e
refactor: make deprecated properties protected
kenjis Oct 20, 2023
9e05289
docs: add changelog
kenjis Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions system/HTTP/IncomingRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,9 @@ class IncomingRequest extends Request
* AFTER the baseURL. So, if hosted in a sub-folder this will
* appear different than actual URI path. If you need that use getPath().
*
* @deprecated Will be protected. Use getUri() instead.
*
* @var URI
*/
public $uri;
protected $uri;

/**
* The detected URI path (relative to the baseURL).
Expand Down Expand Up @@ -125,10 +123,8 @@ class IncomingRequest extends Request
* Configuration settings.
*
* @var App
*
* @deprecated Will be protected.
*/
public $config;
protected $config;

/**
* Holds the old data from a redirect.
Expand Down
2 changes: 2 additions & 0 deletions user_guide_src/source/changelogs/v4.5.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ Test
Others
------

- **IncomingRequest::** The visibility of the deprecated properties ``$uri`` and
``$config`` has been changed to protected.
- **Config:** The deprecated ``CodeIgniter\Config\Config`` class has been removed.

Enhancements
Expand Down
Loading