Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change make:command default $group to App #8109

Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix: change make:command default $group to App #8109

merged 1 commit into from
Oct 28, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 28, 2023 •
edited
Loading

Description
CodeIgniter is already used for the framework commands.

CodeIgniter
  env                Retrieves the current environment, or set a new one.
  filter:check       Check filters for a route.
  help               Displays basic usage information.
  list               Lists the available commands.
  namespaces         Verifies your namespaces are setup correctly.
  publish            Discovers and executes all predefined Publisher classes.
  routes             Displays all routes.
  serve              Launches the CodeIgniter PHP-Development Server.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
fix: change make:command default $group to App
42d77d6 
`CodeIgniter` is already used for the framework commands.

CodeIgniter
  env                Retrieves the current environment, or set a new one.
  filter:check       Check filters for a route.
  help               Displays basic usage information.
  list               Lists the available commands.
  namespaces         Verifies your namespaces are setup correctly.
  publish            Discovers and executes all predefined Publisher classes.
  routes             Displays all routes.
  serve              Launches the CodeIgniter PHP-Development Server.
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 28, 2023
MGatner
MGatner approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes definitely a good change. We should probably be reserving the framework group due to security concerns, but this is a good step.

@kenjis kenjis merged commit b0d8fd8 into codeigniter4:develop Oct 28, 2023
62 checks passed
@kenjis kenjis deleted the fix-spark-make-command branch October 28, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner