Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ArrayHelper::dotKeyExists() #8131

Merged
merged 3 commits into from
Nov 6, 2023
Merged

feat: add ArrayHelper::dotKeyExists() #8131

merged 3 commits into from
Nov 6, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 31, 2023 •
edited
Loading

Needs #8130

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Oct 31, 2023
@kenjis kenjis marked this pull request as draft October 31, 2023 06:04
@kenjis kenjis mentioned this pull request Oct 31, 2023
Merged
5 tasks
@kenjis kenjis force-pushed the feat-ArrayHelper-dotKeyExists branch 2 times, most recently from d1930b8 to 7ee981a Compare October 31, 2023 06:34
@kenjis kenjis mentioned this pull request Oct 31, 2023
Closed
5 tasks
@kenjis kenjis force-pushed the feat-ArrayHelper-dotKeyExists branch 2 times, most recently from 9101a92 to c107070 Compare November 3, 2023 00:44
@kenjis kenjis marked this pull request as ready for review November 3, 2023 00:45
MGatner
MGatner approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice recursive implementation.

system/Helpers/Array/ArrayHelper.php Show resolved Hide resolved
@kenjis kenjis force-pushed the feat-ArrayHelper-dotKeyExists branch from 3531245 to dce6576 Compare November 6, 2023 01:13
@kenjis kenjis merged commit e875b05 into codeigniter4:4.5 Nov 6, 2023
45 checks passed
@kenjis kenjis deleted the feat-ArrayHelper-dotKeyExists branch November 6, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner