Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove deprecated ModelFactory #8139

Merged
merged 1 commit into from
Nov 5, 2023
Merged

refactor: remove deprecated ModelFactory #8139

merged 1 commit into from
Nov 5, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 3, 2023

Description

  • remove depreacted ModelFactory

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code breaking change Pull requests that may break existing functionalities 4.5 labels Nov 3, 2023
@MGatner MGatner changed the title refactor: remove depreacted ModelFactory refactor: remove deprecated ModelFactory Nov 5, 2023
MGatner
MGatner approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geez I forgot this was a thing! 🚮

@kenjis kenjis merged commit b58a168 into codeigniter4:4.5 Nov 5, 2023
46 checks passed
@kenjis kenjis deleted the remove-ModelFactory branch November 5, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner