Skip to content

fix: force_https() redirects to wrong URL when baseURL has subfolder #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenjis merged 2 commits into from
Nov 16, 2023
Merged

fix: force_https() redirects to wrong URL when baseURL has subfolder #8191

kenjis merged 2 commits into from
Nov 16, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Nov 11, 2023 •
edited
Loading

Description
Fixes #8190

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 11, 2023
@kenjis kenjis force-pushed the fix-force_https branch 2 times, most recently from 3e46628 to 2751f48 Compare November 12, 2023 02:16
@kenjis kenjis mentioned this pull request Nov 12, 2023
Closed
@kenjis kenjis force-pushed the fix-force_https branch 2 times, most recently from a760dbf to 486bcc7 Compare November 12, 2023 07:44
@kenjis kenjis marked this pull request as draft November 12, 2023 10:48
@kenjis kenjis force-pushed the fix-force_https branch 2 times, most recently from d268ba0 to afcdcfc Compare November 12, 2023 11:07
@kenjis kenjis closed this Nov 12, 2023
@kenjis kenjis reopened this Nov 12, 2023
@kenjis kenjis marked this pull request as ready for review November 12, 2023 11:07
datamweb
datamweb approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the stale Pull requests with conflicts label Nov 14, 2023
@github-actions
Copy link

github-actions bot commented Nov 14, 2023

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis removed the stale Pull requests with conflicts label Nov 14, 2023
@kenjis kenjis merged commit 6a7fd1e into codeigniter4:develop Nov 16, 2023
@kenjis kenjis deleted the fix-force_https branch November 16, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Forcing Global Secure Requests does not work when the baseURL has more than a scheme and an authority

3 participants

@kenjis @michalsn @datamweb