Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ExceptionHandler displays incorrect Exception classname #8239

Merged
merged 3 commits into from
Nov 26, 2023
Merged

fix: ExceptionHandler displays incorrect Exception classname #8239

merged 3 commits into from
Nov 26, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 21, 2023 •
edited
Loading

Description
Follow-up #7341
From Slack

  • display all Exceptions
  • log all Exceptions

It shows the first Exception, but devs must catch the thrown Exception.

Before:
Screenshot 2023-11-21 10 41 31

After:
Screenshot 2023-11-21 12 05 12

Before:
Screenshot 2023-11-21 12 07 18

After:
Screenshot 2023-11-21 12 07 36

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 21, 2023
@kenjis kenjis marked this pull request as draft November 21, 2023 01:28
@kenjis kenjis changed the title fix: bug where ExceptionHandler displays incorrect Exception classname fix: ExceptionHandler displays incorrect Exception classname Nov 21, 2023
@kenjis kenjis force-pushed the fix-ExceptionHandler-exception-display branch 2 times, most recently from 151a168 to b27f02d Compare November 21, 2023 01:48
@kenjis kenjis marked this pull request as ready for review November 21, 2023 01:49
@kenjis kenjis marked this pull request as draft November 21, 2023 02:31
@kenjis kenjis force-pushed the fix-ExceptionHandler-exception-display branch from b27f02d to 74e236b Compare November 21, 2023 03:05
@kenjis
fix: bug where ExceptionHandler displays incorrect Exception classname
2ec8ff5 
It showed the first Exception, but devs must catch the thrown Exception.
@kenjis kenjis force-pushed the fix-ExceptionHandler-exception-display branch from 74e236b to 2ec8ff5 Compare November 21, 2023 03:15
@kenjis kenjis marked this pull request as ready for review November 21, 2023 03:57
@kenjis kenjis marked this pull request as draft November 21, 2023 09:45
@kenjis kenjis marked this pull request as ready for review November 21, 2023 10:11
@kenjis kenjis merged commit 8657525 into codeigniter4:develop Nov 26, 2023
62 checks passed
@kenjis kenjis deleted the fix-ExceptionHandler-exception-display branch November 26, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn