Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: apply SimplifyEmptyCheckOnEmptyArrayRector #8341

Merged
merged 4 commits into from
Dec 19, 2023
Merged

refactor: apply SimplifyEmptyCheckOnEmptyArrayRector #8341

merged 4 commits into from
Dec 19, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 17, 2023 •
edited
Loading

Description

  • replace empty()

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Dec 17, 2023
@kenjis kenjis mentioned this pull request Dec 18, 2023
Merged
2 tasks
michalsn
michalsn approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty() is a quite popular function. Nice.

@kenjis kenjis merged commit 4433c90 into codeigniter4:develop Dec 19, 2023
61 checks passed
@kenjis kenjis deleted the add-SimplifyEmptyCheckOnEmptyArrayRector branch December 19, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @samsonasik