Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DOMParser cannot see element with id="0" #8360

Merged
merged 5 commits into from
Dec 25, 2023
Merged

fix: DOMParser cannot see element with id="0" #8360

merged 5 commits into from
Dec 25, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 22, 2023

Description

  • fix bug with empty()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 22, 2023
@kenjis kenjis merged commit bd0fbe9 into codeigniter4:develop Dec 25, 2023
61 checks passed
@kenjis kenjis deleted the fix-DOMParser branch December 25, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn