Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Validation::run() accepts DB connection #8499

Merged
merged 3 commits into from
Feb 7, 2024
Merged

feat: Validation::run() accepts DB connection #8499

merged 3 commits into from
Feb 7, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 1, 2024 •
edited
Loading

Description
Closes #6723
Supersedes #8188

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities breaking change Pull requests that may break existing functionalities 4.5 labels Feb 1, 2024
@kenjis kenjis mentioned this pull request Feb 1, 2024
Closed
5 tasks
@kenjis kenjis merged commit 846466e into codeigniter4:4.5 Feb 7, 2024
47 checks passed
@kenjis kenjis deleted the feat-Validation-run-DB-connection branch February 7, 2024 01:18
@kenjis kenjis mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb