Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 404 Override sets 404 by default #8535

Merged
merged 2 commits into from
Feb 17, 2024
Merged

feat: 404 Override sets 404 by default #8535

merged 2 commits into from
Feb 17, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 11, 2024

Description
The 404 Override feature should set 404 by default, because it is for 404 pages.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities breaking change Pull requests that may break existing functionalities 4.5 labels Feb 11, 2024
@kenjis kenjis merged commit b72ae46 into codeigniter4:4.5 Feb 17, 2024
47 checks passed
@kenjis kenjis deleted the feat-404override-sets-404 branch February 17, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @michalsn @samsonasik @datamweb