Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.5] fix: $db->dateFormat merge #8539

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[4.5] fix: $db->dateFormat merge #8539

merged 2 commits into from
Feb 12, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 12, 2024 •
edited
Loading

Description
Follow-up #8525

Fix bug where the initial property array were overwritten and elements were deleted.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.5 labels Feb 12, 2024
@kenjis kenjis mentioned this pull request Feb 12, 2024
Merged
11 tasks
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Feb 12, 2024
@kenjis kenjis changed the title fix: $db->dateFormat merge [4.5] fix: $db->dateFormat merge Feb 12, 2024
@kenjis kenjis merged commit 01e1a46 into codeigniter4:4.5 Feb 12, 2024
46 checks passed
@kenjis kenjis deleted the fix-db-dateFormat-merge branch February 12, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn