fix: [DebugBar] scroll to top

[ddevsr]

Description
Fixed #8594

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[acpadhi]

Thanks, however, this does not fix issue across the debugbar. Only fixes the toggle icon. I have uploaded 2 files in #8594 which seem to fix it for me across all links in the debugbar. Please refer to #8594 to download a zip with the changed files.

[ddevsr]

@acpadhi Updated all button

[acpadhi]

Thanks, but Line Number : 31 - role="button" missing, so when debugbar is closed, cursor change not working when hover on toggle button.

<div id="debug-icon" class="debug-bar-ndisplay"> <a id="debug-icon-link">

There is another issue in the debugbar, when the View button is clicked, it does not highlight as selected button. Rest all buttons in the toolbar get highligted when they are toggled. Should this go as a separate issue or can be handled in this PR itself ?

[kenjis]

@acpadhi

when debugbar is closed, cursor change not working when hover on toggle button.

What do you mean? What is the toggle button?

[ddevsr]

@acpadhi Can you record?

[paulbalandan]

No need for this comment, in my opinion.

[ddevsr]

Done

[acpadhi]

@kenjis
Bottom right corner in development mode in debugbar closed state.

MouseOver on that icon does not change Cursor, since role=button is missing for that anchor tag.

[acpadhi]

@ddevsr
Since you are working on the CSS/SCSS, please look into this as well :

In debugbar when someone clicks on the Views button to show the views higlighted in the page, the button in the toolbar should also have a darker background to highlight that the views button has been toggled to an ON state, just like how the other buttons in the debugbar behave. If this is confusing, please let me know and I will write back again to explain.

[kenjis]

@acpadhi

2024-03-05.14.21.59.mov

[kenjis]

In debugbar when someone clicks on the Views button to show the views higlighted in the page, the button in the toolbar should also have a darker background to highlight that the views button has been toggled to an ON state, just like how the other buttons in the debugbar behave.

"Views" tab shows nothing, so isn't the behavior intentional?
At least, the behavior is the same in v4.0.1.

Clicked "Files":

and clicked "Views":

[acpadhi]

@kenjis

"Views" tab shows nothing, so isn't the behavior intentional?
At least, the behavior is the same in v4.0.1.

In my Opinion, it is kind of not directly imminent that that the view button is clicked, I understant that there is border highlithing on page view areas, but when working on a large pages, visually it can be distracting to see gaps in design and wondering if some css is causing it. A dark background in the button will immediately convey "Oh my debugbar view button is toggled, so I see the gaps" . This is not a pressing thing, just a suggestion to keep consistency, since afterall it is a toggle, irrespective of whenther showing additional content or not.

[kenjis]

@acpadhi Ah, I got what you say. You say it is better that when the "Views" is on, the "Views" is darker.
It would certainly be better that way.

[acpadhi]

Ah, I got what you say. You say it is better that when the "Views" is on, the "Views" is darker.
It would certainly be better that way.

Yes, that way this Views button will be conistent with other buttons on the visual aspect, and also make it exlicit that it is in ON state.

[kenjis]

@acpadhi I agree with your opinion. But the current behavior is not a bug. So changing it will be an enhancement.

This PR seems good to me.

[ddevsr]

@acpadhi Ah, i see. If view button already click, marking is ACTIVE right?

@kenjis Next PR?

[kenjis]

@ddevsr It is an enhancement, not a bug fix. Please send a new PR to 4.5 if you send.

Needs more consideration

[kenjis]

The following error will be fixed by #8612.

 Error: Ignored error pattern #^Cannot unset offset string on array\<int, int\>\|null\.$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/Mock/MockCache.php was not matched in reported errors.
 ------ ---------------------------------------------------------------------------- 
  Line   system/Test/Mock/MockCache.php                                              
 ------ ---------------------------------------------------------------------------- 
         Ignored error pattern #^Cannot unset offset string on array<int,            
         int>\|null\.$# in path                                                      
         /home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/Mock/MockCache.php  
         was not matched in reported errors.                                         
 ------ ---------------------------------------------------------------------------- 

https://github.com/codeigniter4/CodeIgniter4/actions/runs/8210351538/job/22457631537?pr=8595

[kenjis]

LGTM!