Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Config\Optimize #8605

Merged
merged 9 commits into from
Mar 27, 2024
Merged

feat: add Config\Optimize #8605

merged 9 commits into from
Mar 27, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 4, 2024 •
edited
Loading

Needs #8604

Description

  • add config to enable caching features
    • Config\Optimize::$configCacheEnabled
    • Config\Optimize::$locatorCacheEnabled

Config\Optimize does not extend BaseConfig intentionally.
Because simple plain small class is very fast to instantiate. See #8558 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Mar 4, 2024
@kenjis kenjis marked this pull request as draft March 4, 2024 00:44
@kenjis kenjis mentioned this pull request Mar 4, 2024
Closed
5 tasks
@github-actions github-actions bot added the stale Pull requests with conflicts label Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis removed the stale Pull requests with conflicts label Mar 7, 2024
This was referenced Mar 7, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@github-actions github-actions bot added the stale Pull requests with conflicts label Mar 18, 2024
@kenjis kenjis removed the stale Pull requests with conflicts label Mar 18, 2024
@kenjis kenjis marked this pull request as ready for review March 26, 2024 21:27
michalsn
michalsn approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. It is much easier to manage.

@kenjis kenjis merged commit 6fd8afb into codeigniter4:4.5 Mar 27, 2024
41 checks passed
@kenjis kenjis deleted the feat-add-config-optimize branch March 27, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn