New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary BaseService::$services assignment #8609

Merged

kenjis merged 2 commits into codeigniter4:4.5 from kenjis:deprecate-BaseConfig-services

Mar 5, 2024

Member

kenjis commented Mar 5, 2024 •

edited

Loading

Description

deprecate BaseService::$services. It is not used elsewhere.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide


refactor: remove unnecessary $services assignment

91fea1a

kenjis added refactor 4.5 labels


docs: add changelog

3c71913

paulbalandan approved these changes

View reviewed changes

kenjis merged commit 87db593 into codeigniter4:4.5

47 checks passed

kenjis deleted the deprecate-BaseConfig-services branch

March 5, 2024 21:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment