Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Model::shouldUpdate() logic #8614

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: Model::shouldUpdate() logic #8614

merged 1 commit into from
Mar 15, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 10, 2024 •
edited
Loading

Description
Fixes #8613

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 10, 2024
@kenjis kenjis mentioned this pull request Mar 10, 2024
Closed
@kenjis kenjis merged commit a87fd14 into codeigniter4:develop Mar 15, 2024
62 checks passed
@kenjis kenjis deleted the fix-model-save-empty-id branch March 15, 2024 00:24
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [Model] Change in behavior of the save function since 4.4.4
2 participants
@kenjis @datamweb