refactor: move footer info to top in error_exception.php #8626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
datamweb
reviewed
Mar 15, 2024
app/Views/errors/html/debug.css
Outdated
| background: var(--dark-bg-color); | ||
| color: var(--light-text-color); | ||
| } | ||
| .footer .container { | ||
| border-top: 1px solid #e7e7e7; |
There was a problem hiding this comment.
Suggested change
| border-top: 1px solid #e7e7e7; |
I think we don't need it.
It is useful when reporting errors.
kenjis
force-pushed
the
refactor-error_exception.php
branch
from
7d3315f
to
50409e8
Compare
ddevsr
suggested changes
Mar 15, 2024
lonnieezell
approved these changes
Mar 15, 2024
ddevsr
approved these changes
Mar 15, 2024
MGatner
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #8616 (comment)
It is useful when reporting errors.
Before:
After:
Checklist: