New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [Rector] Apply ExplicitBoolCompareRector #8704

Merged

samsonasik merged 2 commits into codeigniter4:develop from samsonasik:rector-explicit-bool

Apr 4, 2024

Member

samsonasik commented Apr 3, 2024 •

edited by kenjis

Loading

Description

Make if conditions more explicit and reduce phpstan baseline errors.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide


chore: [Rector] Apply ExplicitBoolCompareRector

0987c9a

samsonasik requested review from kenjis, MGatner and paulbalandan

April 3, 2024 15:27

samsonasik commented

View reviewed changes

system/Database/OCI8/Builder.php Show resolved Hide resolved

Member Author

samsonasik commented Apr 3, 2024

Ready to review 👍

paulbalandan reviewed

View reviewed changes

Member

paulbalandan left a comment

I'm not sure abt the change in strings to === '' and === '0'. Are we really checking for non-falsy-string? Or maybe just non-empty-string?

For the others, I think I'm good with those changes.

Member Author

samsonasik commented Apr 3, 2024

This is the exact equal truthy check to string, which should be safer.

if it only check on empty string "", I can change

kenjis reviewed

View reviewed changes

system/CLI/CLI.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

system/Config/DotEnv.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

system/HTTP/DownloadResponse.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

system/Helpers/form_helper.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

system/Helpers/html_helper.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

system/Helpers/url_helper.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

system/Router/RouteCollection.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

system/Session/Handlers/FileHandler.php Outdated Show resolved Hide resolved

kenjis added the refactor label

kenjis changed the title ~~chore: [Rector] Apply ExplicitBoolCompareRector~~ refactor: [Rector] Apply ExplicitBoolCompareRector


remove !== "0" check

1455e8d

Member Author

samsonasik commented Apr 4, 2024

@kenjis I updated to remove !== "0" check 👍

samsonasik requested review from kenjis and paulbalandan

April 4, 2024 08:40

kenjis approved these changes

View reviewed changes

Member Author

samsonasik commented Apr 4, 2024

Ready to merge 👍

paulbalandan approved these changes

View reviewed changes

Member Author

samsonasik commented Apr 4, 2024

Let's merge it, thank you @paulbalandan @kenjis for the review 👍

samsonasik merged commit 57c0c5a into codeigniter4:develop

55 checks passed

samsonasik deleted the rector-explicit-bool branch

April 4, 2024 09:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment