Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor Config/Registrar.php #8731

Merged
merged 3 commits into from
Apr 10, 2024
Merged

test: refactor Config/Registrar.php #8731

merged 3 commits into from
Apr 10, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 9, 2024 •
edited
Loading

Description
See #8732

  • replace empty()
  • add types

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only refactor Pull requests that refactor code labels Apr 9, 2024
@kenjis kenjis force-pushed the refactor-test-Registrar.php branch from f171167 to d3a03a7 Compare April 9, 2024 06:52
@kenjis kenjis merged commit 2c524fd into codeigniter4:develop Apr 10, 2024
38 checks passed
@kenjis kenjis deleted the refactor-test-Registrar.php branch April 10, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn