Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: system/View/Plugins.php #8742

Merged

Conversation

mcsaygili
Copy link
Contributor

@mcsaygili mcsaygili commented Apr 9, 2024

Description
See #8732

  • add types

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@mcsaygili mcsaygili changed the title test: refactor system/View/Plugins.php refactor: system/View/Plugins.php Apr 9, 2024
@kenjis kenjis added the refactor Pull requests that refactor code label Apr 10, 2024
@mcsaygili mcsaygili force-pushed the refactor-system-View-Plugins.php branch from e41ea43 to 3c898d0 Compare April 10, 2024 07:02
@kenjis
Copy link
Member

kenjis commented Apr 10, 2024

The first commit message:

test: refactor system/View/Plugins.php

test: means the commit changes only test files.
So the message is wrong.

@mcsaygili mcsaygili force-pushed the refactor-system-View-Plugins.php branch from 03afea6 to be58db7 Compare April 10, 2024 12:00
@mcsaygili mcsaygili force-pushed the refactor-system-View-Plugins.php branch from be58db7 to 234dba2 Compare April 10, 2024 12:04
system/View/Plugins.php Outdated Show resolved Hide resolved
system/View/Plugins.php Outdated Show resolved Hide resolved
system/View/Plugins.php Outdated Show resolved Hide resolved
system/View/Plugins.php Outdated Show resolved Hide resolved
system/View/Plugins.php Outdated Show resolved Hide resolved
mcsaygili and others added 5 commits April 11, 2024 19:31
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
@kenjis kenjis merged commit 22e3450 into codeigniter4:develop Apr 12, 2024
40 checks passed
@kenjis
Copy link
Member

kenjis commented Apr 12, 2024

@mcsaygili Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants