Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix method name ValidationErrors in View\Plugins #8758

Merged
merged 2 commits into from
Apr 12, 2024
Merged

refactor: fix method name ValidationErrors in View\Plugins #8758

merged 2 commits into from
Apr 12, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 11, 2024 •
edited
Loading

Description

  • fix method name
  • add test cases

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Apr 11, 2024
@github-actions github-actions bot added the stale Pull requests with conflicts label Apr 12, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis force-pushed the fix-View-Plugins-ValidationErrors branch from 43b3822 to 7f86e00 Compare April 12, 2024 04:07
@kenjis kenjis removed the stale Pull requests with conflicts label Apr 12, 2024
@kenjis kenjis merged commit 4d5e012 into codeigniter4:develop Apr 12, 2024
40 checks passed
@kenjis kenjis deleted the fix-View-Plugins-ValidationErrors branch April 12, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @datamweb