Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve View pages #8780

Merged
merged 7 commits into from
Apr 16, 2024
Merged

docs: improve View pages #8780

merged 7 commits into from
Apr 16, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 14, 2024

Description

  • minor improvements

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis
docs: add note on view() and View Renderer relationship
799b505
@kenjis
docs: change page order
a25275a 
"Views" page is an explanation of the standard views.
The standard views use View Renderer.
So the two pages should be close.
@kenjis
docs: capitalize first letter
2091c42
@kenjis
docs: decorate method name
3127784
@kenjis
docs: improve description
7b45a2b 
The views in "Views" page is pure PHP views.
It is different from Parser Template views.
So I removed the link to "Views" page.
@kenjis
docs: add section titles and descriptions
4d88c19
@kenjis kenjis added the documentation Pull requests for documentation only label Apr 14, 2024
@kenjis @datamweb
docs: fix typo
9483b35 
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@kenjis kenjis merged commit d425bdf into codeigniter4:develop Apr 16, 2024
8 checks passed
@kenjis kenjis deleted the docs-improve-views branch April 16, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb requested changes

@paulbalandan paulbalandan paulbalandan approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @datamweb @paulbalandan @ddevsr