Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update preload.php for 4.5 #8805

Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix: update preload.php for 4.5 #8805

merged 2 commits into from
Apr 19, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 19, 2024

Description
Fixes #8801

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 19, 2024
@kenjis kenjis changed the title chore: update reoload.php for 4.5 chore: update preload.php for 4.5 Apr 19, 2024
@kenjis kenjis mentioned this pull request Apr 19, 2024
Closed
@kenjis kenjis changed the title chore: update preload.php for 4.5 fix: update preload.php for 4.5 Apr 19, 2024
ddevsr
ddevsr approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@ddevsr ddevsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou @kenjis!

@samsonasik samsonasik merged commit 6934848 into codeigniter4:develop Apr 19, 2024
40 checks passed
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-preload.php branch April 19, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: bootstrap on preload not updated to last v4.5.1
4 participants
@kenjis @samsonasik @paulbalandan @ddevsr