Skip to content

refactor: remove depreacted ResponseInterface::getReason() #8841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2024
Merged

refactor: remove depreacted ResponseInterface::getReason() #8841

merged 1 commit into from
May 1, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 30, 2024 •
edited
Loading

Description
See https://codeigniter4.github.io/CodeIgniter4/installation/upgrade_405.html#message-getheader-s

  • remove deprecated ResponseInterface::getReason()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code breaking change Pull requests that may break existing functionalities labels Apr 30, 2024
@kenjis kenjis changed the title refactor!: remove depreacted ResponseInterface::getReason() refactor: remove depreacted ResponseInterface::getReason() Apr 30, 2024
@kenjis kenjis added the 4.6 label Apr 30, 2024
@kenjis kenjis merged commit 5f31af1 into codeigniter4:4.6 May 1, 2024
41 checks passed
@kenjis kenjis deleted the remove-deprecated-Response-getReason branch May 1, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb