Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FileCollection pseudo-regex #8868

Merged
merged 4 commits into from
May 10, 2024
Merged

fix: FileCollection pseudo-regex #8868

merged 4 commits into from
May 10, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 8, 2024

Description
Fixes a bug that the pseudo-regex '*_?.php' matches fig_3.php.txt.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label May 8, 2024
@kenjis kenjis force-pushed the fix-FileCollection-pseudo-regex branch from d57a5f7 to 700612c Compare May 8, 2024 05:34
@kenjis kenjis merged commit fd0a3b6 into codeigniter4:develop May 10, 2024
40 checks passed
@kenjis kenjis deleted the fix-FileCollection-pseudo-regex branch May 10, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb