docs: Fix some typos in helpers/html_helper.rst #8916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some typos in helpers/html_helper.rst
Add alt attribute to img element in helpers/html_helper/002.php
kenjis
reviewed
May 27, 2024
Comment on lines
-278
to
+288
| .. php:function:: embed($src = ''[, $type = false[, $attributes = ''[, $indexPage = false]]]) | ||
| .. php:function:: track($src, $kind, $srcLanguage, $label) | ||
|
|
||
| :param string $src: The path of the media resource | ||
| :param string $kind: The kind of timed track | ||
| :param string $srcLanguage: The language of the timed track | ||
| :param string $label: A user-readable title for the timed track | ||
| :returns: An HTML track element | ||
| :rtype: string | ||
|
|
||
| Generates a track element to specify timed tracks. The tracks are | ||
| formatted in WebVTT format. Example: | ||
|
|
||
| .. literalinclude:: html_helper/019.php |
There was a problem hiding this comment.
These differences make it difficult to review.
I don't know why track() location was changed.
Please create one commit for changing the location.
Also, there are too many diffs in one commit.
Many fixes are corrections of errors, and they are too large to be called typos.
Please create a commit with a commit message of why you changed for every single meaningful fix.
ddevsr
reviewed
May 28, 2024
| Presumably, this would be if you were using a media controller: | ||
| There is an optional second parameter, a true/false value, that | ||
| specifies if the *src* should have ``$config['indexPage']`` added to the address it creates. | ||
| Presumably, this would be true if you were using a media controller???: |
There was a problem hiding this comment.
Suggested change
| Presumably, this would be true if you were using a media controller???: | |
| Presumably, this would be true if you were using a media controller: |
kenjis
added
the
needs rework
paulbalandan
approved these changes
Jun 10, 2024
kenjis
requested changes
Aug 12, 2024
kenjis
added
the
waiting for info
|
👋 Hi, @obozdag! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix some typos in helpers/html_helper.rst
Checklist: