Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused path parameter on PhpStreamWrapper::stream_open() #8926

Merged
merged 1 commit into from
May 30, 2024
Merged

refactor: remove unused path parameter on PhpStreamWrapper::stream_open() #8926

merged 1 commit into from
May 30, 2024

Conversation

samsonasik
Copy link
Member

Description

Detected by latest rector rule: RemoveUnusedPublicMethodParameterRector

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik samsonasik changed the title chore: remove unused path parameter on PhpStreamWrapper::stream_open() refactor: remove unused path parameter on PhpStreamWrapper::stream_open() May 30, 2024
@samsonasik
Copy link
Member Author

Ready to merge 👍

@ddevsr ddevsr added the refactor Pull requests that refactor code label May 30, 2024
@samsonasik
Copy link
Member Author

Thank you @michalsn for the review, let's merge 👍

@samsonasik samsonasik merged commit 19e62ac into codeigniter4:develop May 30, 2024
41 checks passed
@samsonasik samsonasik deleted the chore-stream-wrapper branch May 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@kenjis kenjis Awaiting requested review from kenjis

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @michalsn @ddevsr