-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: View::renderSection() return type #8965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: View::renderSection() return type #8965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug is old. I came across this a long time ago, not a serious mistake and I agreed with it.
Do you need a return test? For example,
$section = $this->renderSection(”content") ?? ”Not content";
2990303
to
bff0841
Compare
Added a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
ok thank you @kenjis .. do you think Is better to wait the 4.6.0 then? |
If you want this soon, patch |
Description
From https://forum.codeigniter.com/showthread.php?tid=91082
The method should not use
echo
, because it has side effects.Checklist: