Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: BaseBuilder::orderBy() #8970

Merged
merged 2 commits into from
Jun 19, 2024
Merged

refactor: BaseBuilder::orderBy() #8970

merged 2 commits into from
Jun 19, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 18, 2024

Description

  • refactor

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code database Issues or pull requests that affect the database layer labels Jun 18, 2024
@kenjis kenjis changed the title refactor: BaseBuilder::orderBy() refactor: BaseBuilder::orderBy() Jun 18, 2024
@kenjis kenjis merged commit d6d1434 into codeigniter4:develop Jun 19, 2024
41 checks passed
@kenjis kenjis deleted the refactor-orderBy branch June 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @ddevsr