Skip to content

[4.6] fix: add validation message for min_dims #8988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2024
Merged

[4.6] fix: add validation message for min_dims #8988

merged 3 commits into from
Jun 24, 2024

Conversation

christianberkman
Copy link
Contributor

@christianberkman christianberkman commented Jun 22, 2024 •
edited
Loading

Description
Add missing validation message for min_dims validation rule introduced in #8966

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.6 bug Verified issues on the current code behavior or pull requests that will fix them labels Jun 22, 2024
kenjis
kenjis previously approved these changes Jun 22, 2024
View reviewed changes
@kenjis kenjis changed the title fix: add validation message for min_dims [4.6] fix: add validation message for min_dims Jun 22, 2024
@kenjis
Copy link
Member

kenjis commented Jun 22, 2024

Please add it in the changelog "Message Changes".
https://github.com/codeigniter4/CodeIgniter4/blob/4.6/user_guide_src/source/changelogs/v4.6.0.rst#message-changes
E.g., https://codeigniter4.github.io/CodeIgniter4/changelogs/v4.5.0.html#message-changes

@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Jun 22, 2024
@kenjis kenjis dismissed their stale review June 22, 2024 09:27

docs needed

@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Jun 22, 2024
@christianberkman @kenjis
Update user_guide_src/source/changelogs/v4.6.0.rst
dba7443 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@kenjis kenjis merged commit d4fee13 into codeigniter4:4.6 Jun 24, 2024
42 checks passed
@kenjis
Copy link
Member

kenjis commented Jun 24, 2024

@christianberkman Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christianberkman @kenjis @michalsn @datamweb