Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [QueryBuilder] select() with RawSql may cause TypeError #9009

Merged
merged 7 commits into from
Jul 1, 2024
Merged

fix: [QueryBuilder] select() with RawSql may cause TypeError #9009

merged 7 commits into from
Jul 1, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 28, 2024 •
edited
Loading

Description
Fixes #9007

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
test: add test for select() with RawSql
43ce135
@kenjis
fix: select() may cause TypeError
1962e8c 
TypeError: trim(): Argument #1 ($string) must be of type string, CodeIgniter\Database\RawSql given
@kenjis
refactor: rename variable name
73d67fb
@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jun 28, 2024
@kenjis kenjis mentioned this pull request Jun 28, 2024
Closed
@kenjis kenjis requested a review from maniaba June 28, 2024 10:22
@kenjis kenjis requested a review from maniaba June 28, 2024 11:28
@kenjis kenjis merged commit e7cb689 into codeigniter4:develop Jul 1, 2024
41 checks passed
@kenjis kenjis deleted the fix-qb-select-rawsql branch July 1, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

@maniaba maniaba maniaba approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
4 participants
@kenjis @michalsn @datamweb @maniaba