Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [QueryBuilder] select() does not escape after NULL #9010

Merged
merged 3 commits into from
Jul 1, 2024
Merged

fix: [QueryBuilder] select() does not escape after NULL #9010

merged 3 commits into from
Jul 1, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 28, 2024 •
edited
Loading

Description
Follow-up #1169

Fixes bug that select() does not escape items after NULL.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jun 28, 2024
@kenjis
refactor: remove duplicated trim()
227f53a 
It is already trimmed in Line 415.
@kenjis kenjis merged commit 90cff96 into codeigniter4:develop Jul 1, 2024
41 checks passed
@kenjis kenjis deleted the fix-qb-select-null-escape branch July 1, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb