Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: referrer is undefined #9059

Merged
merged 1 commit into from
Jul 23, 2024
Merged

docs: referrer is undefined #9059

merged 1 commit into from
Jul 23, 2024

Conversation

totoprayogo1916
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 commented Jul 22, 2024 •
edited by kenjis
Loading

Description
referrer is undefined, but getReferrer available
see:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/system/HTTP/UserAgent.php
https://codeigniter4.github.io/userguide/libraries/user_agent.html#CodeIgniter\HTTP\UserAgent::getReferrer

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the documentation Pull requests for documentation only label Jul 22, 2024
michalsn
michalsn approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 23, 2024
@kenjis kenjis merged commit bbc7608 into codeigniter4:develop Jul 23, 2024
9 checks passed
@kenjis
Copy link
Member

kenjis commented Jul 23, 2024

@totoprayogo1916 Thank you!

@totoprayogo1916 totoprayogo1916 deleted the patch-2 branch July 23, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@totoprayogo1916 @kenjis @michalsn @ddevsr