Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: BaseBuilder #9157

Merged
merged 3 commits into from
Aug 30, 2024
Merged

refactor: BaseBuilder #9157

merged 3 commits into from
Aug 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 28, 2024

Description
Follow-up #9156

  • remove uneeded if condition

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Aug 28, 2024
@kenjis kenjis merged commit c326cd1 into codeigniter4:develop Aug 30, 2024
41 checks passed
@kenjis kenjis deleted the refactor-BaseBuilder branch August 30, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn